Skip to content

Commit

Permalink
fixed issues with BulkEdtior (dialog not closing and other dialog sho… (
Browse files Browse the repository at this point in the history
#297)

* fixed issues with BulkEdtior (dialog not closing and other dialog showing wrong button)

- closes #296

* formatting
  • Loading branch information
foxriver76 authored Jan 9, 2024
1 parent 1e4df40 commit 2dd9e1a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ E.g., if it was used in a menu and the menu is red, the circle would be red.
### **WORK IN PROGRESS**
* (foxriver76) fixed last change y-offset for some widgets
* (foxriver76) fixed issue where JquiState did not respect data type
* (foxriver76) fixed issues with BulkEdtior (dialog not closing and other dialog showing wrong button)

### 2.9.13 (2024-01-08)
* (foxriver76) correctly detect IDs in bindings when they contain hash character
Expand Down
6 changes: 3 additions & 3 deletions src/src/Vis/Widgets/JQui/BulkEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ interface BulkEditorState {
iconDialog: null | number;
imageDialog: null | number;
dialog: boolean;
dialogDelete: null | false | number;
dialogDelete: null | number;
numbers?: boolean;
}

Expand Down Expand Up @@ -394,7 +394,7 @@ class BulkEditor extends React.Component<BulkEditorProps, BulkEditorState> {
// @ts-expect-error this is fine
color="grey"
startIcon={<Close />}
onClick={() => this.setState({ dialogDelete: false })}
onClick={() => this.setState({ dialogDelete: null })}
>
{I18n.t('Cancel')}
</Button>
Expand Down Expand Up @@ -696,7 +696,7 @@ class BulkEditor extends React.Component<BulkEditorProps, BulkEditorState> {
{this.state.values[i]}
<IconButton
size="small"
onClick={() => this.setState({ editDialog: { add: false, index: i, value: this.state.values[i] } })}
onClick={() => this.setState({ editDialog: { add: true, index: i, value: this.state.values[i] } })}
>
<Edit />
</IconButton>
Expand Down

0 comments on commit 2dd9e1a

Please sign in to comment.