Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Do not allow beta to override stable repository if both active #2935

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

GermanBluefox
Copy link
Contributor

@GermanBluefox GermanBluefox commented Oct 3, 2024

  • Do not allow to be active together the stable and beta repositories.
  • Allow addressing the repositories by index in the table

To avoid such a situation
image

Tests

  • I have added tests to avoid a recursion of this bug
  • It is not possible to test for this bug

Only CLI files changed

Documentation

  • I have documented the new feature

Copy link
Collaborator

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly is the point of working with index? This adds a lot of edge cases as you can see in the code you needed to add. In fact you can not assume any order anyway, so what exactly is the point here?

if it gets easier we could also not use a joined parameter "name/index" but use different comands that use index which makes it easier too

packages/cli/src/lib/setup.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/setup.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/setup/setupRepo.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/setup/setupRepo.ts Outdated Show resolved Hide resolved
foxriver76
foxriver76 previously approved these changes Oct 4, 2024
@foxriver76 foxriver76 changed the title [Feature] Do not allow to be active together the stable and beta repositories. [Feature] Do not allow beta to override stable repository if both active Nov 10, 2024
@foxriver76 foxriver76 requested a review from Apollon77 November 10, 2024 08:51
@GermanBluefox
Copy link
Contributor Author

GermanBluefox commented Nov 17, 2024

I still do not understand, If we have index, why not to use it instead of writing "my repo" ?
Same logic is used for restoring

@foxriver76
Copy link
Collaborator

I still do not understand, If we have index, why not to use it instead of writing "my repo" ? Same logic is used for restoring

Hm index is now supported? but of course not for add or addset just for setand del, as the index will just be the next free and you cannot specify like 100 out of nowhere. Or what is the problem now?

@foxriver76 foxriver76 merged commit 1e3f92f into master Nov 19, 2024
15 checks passed
@foxriver76 foxriver76 deleted the repo-cli branch November 19, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants