Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MIGRATION.md #28

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Update MIGRATION.md #28

merged 3 commits into from
Dec 12, 2024

Conversation

mcm1957
Copy link
Contributor

@mcm1957 mcm1957 commented Dec 12, 2024

npm uninstall eslint-plugin-security should be removed too

@foxriver76
Copy link
Contributor

Never seen this plugin, I don't think it is very common. Before we add every edgy package, maybe we should leave a sentence to explain to uninstall all eslint plugins which are not afterwards added again to the new config. I mean someone could use this plugin again with the config if he wants to? It also works with flat config .. https://www.npmjs.com/package/eslint-plugin-security

@mcm1957
Copy link
Contributor Author

mcm1957 commented Dec 12, 2024

OK, I agree that there could be some additional rule files.

I do not know where / when eslint-plugin-securita was invented but it was part of a discussion at Telegram and I no stubled at it when migrating srm adapter to community.

So I added an extra paragraph. Please read and feel free to adapt. I would like to guide those users who do not know what this plgin is good for to remiove it while ist comüpletly ok to leave / add ist for those who want to use these checks.

Copy link
Contributor

@foxriver76 foxriver76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just a small "typo"

MIGRATION.md Outdated Show resolved Hide resolved
@foxriver76 foxriver76 merged commit 622802c into ioBroker:main Dec 12, 2024
@mcm1957
Copy link
Contributor Author

mcm1957 commented Dec 12, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants