-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove private messages after specific cache duration #1333
base: staging
Are you sure you want to change the base?
Conversation
Please also coordinate this with the uu.de team members, as this change will have an impact on the documentation of communication between team members with users |
I will, definitely before the next release. Could an option also be to disable this by default for team members? |
Could be a suitable mitigation, yes. But I wonder why deleting the messages from Inbox and Sent is necessary in the first place. |
The contents of most messages should be fairly trivial, in most cases; probably they are never again looked at, and all take space. More important material can still be archived. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, to the inline comments: is_team_member
exists, if messages should not be deleted for them.
I'll come back to this soon, sorry, I was quite busy with other things lately. |
649b1d0
to
6ca5158
Compare
This should be ready for another round of review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my perspective. Just found some minor details.
hm, we haven't created an team-internal discussion, yet... I can start it after the deployment this evening.
This will not affect messages in the 'archive' folder.
81eeddf
to
9d94344
Compare
Done! |
9d94344
to
a1cb9d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me.
Now we just have to publish a Ikhaya article on https://ubuntuusers.de/, so people now about it.
- article published a month ago → merge
This will not affect messages in the 'archive' folder. Closes #372. Probably also a configuration option should be created for this, in case users want to disable it? At least there'll have to be an announcement for the changed behaviour.