Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be related to #49 , but given the original ticket was not about esbuild, this is more related to one of the replies there.
I'm using
serverless-esbuild
/serverless-offline
to run my code.resolved
variable in app-root-path'sresolve.js
is resolving to'/my/path/to/project/.esbuild/.build/src'
appRootPath
is being returned as'/my/path/to/project/node_modules/serverless-offline/src/lambda/handler-runner/worker-thread-runner'
appRootPath = path.dirname(process.argv[1]);
/my/path/to/project/
By changing
getFirstPartFromNodeModules
togetFirstPart
and having it look for either node_modules or esbuild, it seems to solve this issue for me.I thought about doing something like the following, if it would be preferred: