Add omitempty to fields that can be empty according to KSeF schema #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current implementation did not mark every field that can be omited as such. This could make it so empty fields would be still present in the generated xml files which we don't want. In the commit we mark optional fields with the omitempty keyword and we also make some methods that are only used internally less visible outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation did not mark every field that can be omited as such. This could make it so empty fields would be still present in the generated xml files which we don't want.
In the commit we mark optional fields with the omitempty keyword and we also make some methods that are only used internally less visible outside.