Merge Dfg/sum24-involvemint into Develop #362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johnson Luong <[email protected]> Co-authored-by: Johnson Luong <[email protected]>
…294) Disable the delete offer button when the offer quantity is 0 or less Co-authored-by: Feyi Ogunsanya <[email protected]>
NOTE: Auto-approving this PR since it was previously approved; I'm just putting it through again as I merged into the wrong branch (develop) previously - discussed with @fogunsan and she it was fine to just put it through to here again. Before:  After:  This is identical to behaviour in the `im-image` component, just added one additional CSS style to get the images to be contained within the tile. Also, the change in `init.sql` is a config issue and the new version that I have here was provided by Quinn. --------- Co-authored-by: BKtheInfamous <[email protected]>
### Description This PR addresses issue #271 by changing the text "Posted By" to "Seller Info" in the EP Storefront component. ### Changes Made - Updated the text in `ep-cover.component.html` from "Posted By" to "Seller Info". ### Screenshots  ### Testing - Verified the change locally by navigating to the EP Storefront section in the marketplace and ensuring the text is updated.
balance leftover will now not show a negative value. Instead when i try to send more credits than i already have, the balance leftover will show 0. https://github.com/involveMINT/iMPublic/assets/124219829/0e8cafc2-e286-4671-b718-2ef9be61e7eb
Changed regex to allow for uppercase letters. <img width="224" alt="image" src="https://github.com/involveMINT/iMPublic/assets/57573903/77dd2122-283c-44b3-9de1-5bdd3139b73f"> --------- Co-authored-by: Cam Lee <[email protected]>
… Eye icon to the right on the text box to reveal (#317) I enabled password visibility toggle for both login page and sign up page. https://github.com/involveMINT/iMPublic/assets/106701657/566f5038-0945-4919-aeed-e93023da7b83 --------- Co-authored-by: Feyi Ogunsanya <[email protected]>
…#320) Issue #160 has been fixed: the onboarding popup is no longer able to be closed. Removed the (X) button and also added some code that disables the `dismissBackdrop` property so that it can't be closed until an application option has been filled out. --------- Co-authored-by: BKtheInfamous <[email protected]>
Current implementation involves accessing the `this.user.offers.selectors.offers$` observable and tying their states to the storefronts states if listed as private or unlisted. The offer is changed with `this.user.offers.dispatchers.update`, and the observable triggers a new value, leading to another iteration, thus the throw helps to escape from this loop. Fixed this issue by including a "Take(1)" so that only the first emission is processed. https://github.com/involveMINT/iMPublic/assets/106701657/ac219ebd-123d-4b68-84c9-48a4c3c43346 --------- Co-authored-by: Feyi Ogunsanya <[email protected]>
Exchange partners can add tags to their storefront based on these categories https://docs.google.com/document/d/1tD3F1naFysmMxUuab9IgGEEMS_A_uRUwlE3ny8nL7bc/edit?usp=sharing Users can also see the tags on the business' storefront so they can get an idea of what the business provides/offers https://github.com/user-attachments/assets/c07f9e9b-7fb9-4da3-97af-0b876e5e4d21
2nd pull request for #143 Bug Description The bug involved incorrect decimal formatting for credits in escrow within the wallet section of the application. Instead of displaying the correct value with two decimal places (e.g., 90.00), the application was showing the credits in escrow as whole numbers without decimals (e.g., 9000). Root Cause The issue was caused by the escrowBalance value being handled as a whole number (in cents) without converting it to a formatted decimal value (dollars). code changes this.updateState({ credits, creditsLoaded: loaded, balance: balance / 100, // Correctly format the balance escrowCredits, escrowBalance: escrowBalance / 100, // Correctly format the escrow balance }); the following screenshot shows the change from 2400 to 24.00 after bug fix 
rebased fork, so this is a combination of past closed PR #338 as well as additional implementations of `Enable location services` for EP and SP applications as well. --------- Co-authored-by: BKtheInfamous <[email protected]>
…#360) Added `calculateProjectExpiry` function which sets a project to private if end date is before current day. If a project is expired, it shows up as private for a ServePartner but is still visible. A changemaker will not have access to expired projects when it clicks on the Serve button. https://github.com/user-attachments/assets/1c9413fe-6695-47f8-9333-c1254572f91d Co-authored-by: Feyi Ogunsanya <[email protected]>
…s to depopulate, and the button to clear after I purchase (#361) Co-authored-by: BKtheInfamous <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.