Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature waiver #125

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Feature waiver #125

wants to merge 11 commits into from

Conversation

wengf2086
Copy link
Collaborator

Really sorry about having all these changes in a single commit. I didn't want to risk accidentally committing the environment file again, and I wasn't sure if Robert's changes for the new environment.org.ts file were working and I didn't want to break my code. This isn't how I usually work, I promise I won't do it again!

  • Added waiver to ChangeMaker registration process (user must sign waiver to register as a ChangeMaker)
  • Added boolean field 'hasSignedWaiver' (default: false) to ChangeMaker entity, model, interface, dto, createProfile, user query
  • Upon registration, 'hasSignedWaiver' is set to True
  • Project-specific waiver has been replaced with generalized waiver (same as the one that appears during registration)
  • I've saved the template for the project-specific waiver in case we ever need it again.

When signing up for a project:

  • If the user has signed the general waiver, the waiver will already be accepted and they just need to click submit.
  • If there is a custom waiver, they will only have to review and accept that
    -If the user has NOT signed the general waiver, (they registered as a CM before this change was made), they will have to sign the waiver at project sign-up. After submitting their application, hasSignedWaiver will be set to true. In the future they will not have to sign the waiver again

@rgorham
Copy link
Collaborator

rgorham commented Aug 2, 2023

Are you able to link the work item here? So I know the AC for this?

@wengf2086
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants