Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem of all installed models being assigned "<NOKEY>" #5841

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

lstein
Copy link
Collaborator

@lstein lstein commented Mar 1, 2024

  • Also fix redundant scanning of models directory at startup.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

Two fixes to model manager:

  1. Fix issue of all models being assigned a key of "".
  2. Fix issue of the models directory being scanned and probed at startup time even if no new models added.

Related Tickets & Documents

Issue 1 was reported in discord: https://discord.com/channels/1020123559063990373/1049495067846524939/1212919046526472283

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Try importing models now. They should be assigned random hexadecimal keys in the way the used to be.

Merge Plan

Merge when approved.

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

No.

@github-actions github-actions bot added python PRs that change python files backend PRs that change backend files services PRs that change app services PythonTests labels Mar 1, 2024
Lincoln Stein added 2 commits March 1, 2024 14:03
@hipsterusername hipsterusername merged commit 8fb297e into main Mar 1, 2024
11 checks passed
@hipsterusername hipsterusername deleted the bugfix/no-nokey branch March 1, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files python PRs that change python files services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants