feat(/IPVC-2695): Updates needed to retain HGNC on transcript #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsgiles73
changed the title
nvta1209
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has changes neccessary to keep the HGNC field on the transcript model. One of the original goals was to remove this field, but updates to the HGVS UTA dataprovider were more difficult than anticipated. For the UTA_20240523 release, I added HGNC back to the transcript table outside of the "uta build workflows". We need to keep the Alembic migrations in sync with the database schema, so I went back and made these changes.
During the testing I also discovered that the datatype for the codon_table attribute of the transcript table was wrong. I am not sure where this was introduced, but I changed it from "int" to "text" on the SqlAlchemy model to match the database.