Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(/IPVC-2695): Updates needed to retain HGNC on transcript #45

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

bsgiles73
Copy link

This PR has changes neccessary to keep the HGNC field on the transcript model. One of the original goals was to remove this field, but updates to the HGVS UTA dataprovider were more difficult than anticipated. For the UTA_20240523 release, I added HGNC back to the transcript table outside of the "uta build workflows". We need to keep the Alembic migrations in sync with the database schema, so I went back and made these changes.

  • Add index for hgnc on transcript table
  • Remove Alembic commands that deleted the hgnc column
  • Add hgnc back to the SqlAlchemy models

During the testing I also discovered that the datatype for the codon_table attribute of the transcript table was wrong. I am not sure where this was introduced, but I changed it from "int" to "text" on the SqlAlchemy model to match the database.

@bsgiles73 bsgiles73 changed the title Updates needed to retain HGNC on transcript feat(/IPVC-2695): Updates needed to retain HGNC on transcript Aug 26, 2024
@bsgiles73 bsgiles73 merged commit 684c804 into main Aug 26, 2024
1 check passed
@bsgiles73 bsgiles73 deleted the changes-to-keep-transcript-hgnc branch August 26, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants