docs(app): install doc preening #8420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- headings increased by 2 from h2 to h4, should go one step at a time - internal anchor was incorrect for CLI projects
- gradle 7.3+ has been default for quite some time - multidex is not valid on android minSdk level in place for quite some time - hermes works fine now and has for quite some time - android build memory we suggested as a fix has been default fo rquite some time - manual linking is history from another era
suggested by lint
mikehardy
added
the
Workflow: Needs Review
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lyokone
approved these changes
Mar 24, 2025
mikehardy
commented
Mar 24, 2025
| @@ -201,13 +201,13 @@ To do this, open your `/ios/{projectName}/AppDelegate.mm` file (or `AppDelegate. | |||
|
|
|||
| At the top of the file, import the Firebase SDK right after `'#import "AppDelegate.h"'`: | |||
|
|
|||
| ``` | |||
| ```objectivec | |||
There was a problem hiding this comment.
I think github uses obj-c but I've tried this before, the system we use to generate the docs doesn't work with that and requires objectivec, there's an example in messaging/usage.md which I always have to look at from my previous work to remember which to use, and objectivec is it
MichaelVerdon
approved these changes
Mar 24, 2025
russellwheatley
approved these changes
Mar 24, 2025
mikehardy
removed
the
Workflow: Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was in the area while doing something unrelated and once again realized how out of date some of our install docs sections are, plus there were some errors like a dangling internal page anchor
Fixed them all with separate commits so it's easy to review commit by commit - not that it is a huge PR anyway
Related issues
none logged, fixed rapidly while working on other things
Release Summary
docs commit tag(s), no release triggered
can squash merge
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
if lint passes, it should be good to go
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter