Skip to content

fix(app): annotate initializeApp return as a promise #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix(app): annotate initializeApp return as a promise #8366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/app/lib/modular/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ export function getApps(): FirebaseApp[];
* Initializes a Firebase app with the provided options and name.
* @param options - Options to configure the services used in the app.
* @param name - The optional name of the app to initialize ('[DEFAULT]' if omitted).
* @returns FirebaseApp - The initialized Firebase app.
* @returns Promise<FirebaseApp> - The initialized Firebase app.
*/
export function initializeApp(options: FirebaseAppOptions, name?: string): FirebaseApp;
export function initializeApp(options: FirebaseAppOptions, name?: string): Promise<FirebaseApp>;

/**
* Retrieves an instance of a Firebase app.
Expand Down