-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle custom hosted dependency #288
base: main
Are you sure you want to change the base?
Conversation
@chedwin41 is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/dart_custom_lint~288 Documentation is deployed and generated using docs.page. |
Could you add tests for this? |
I'm having trouble getting the tests to pass. Only 35 out of 75 are passing, even on the master branch, so I think I might be doing something wrong. That said, I've added one test for my case. Let me know if this is sufficient for you. |
Tests are passing on master. Make sure your SDK is up-to-date |
You had a print in your code. That likely caused many tests to fail, as various tests check stdout. |
Note that your test is failing :) |
Hi, I wanted to kindly follow up on this. It seems ready to go. Would it be possible to review and merge if everything looks good? Thank you for your time and for all the great work on this project! 😊 |
Hi @rrousselGit , when do you think you will merge this please ? |
#286