Extract output format to a class structure and add CLI parameter #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add CLI format parameter with currently only one option (default) * implement default format as class * refactor rendering and optimise relative path & fatal handling * only sort lints if the output format requires this (future JSON format does not need this)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rrousselGit
reviewed
Oct 20, 2023
|
I added the JSON output format to this PR. With the class separation it is pretty clean and should be fine to review. |
kuhnroyal
commented
Oct 23, 2023
rrousselGit
reviewed
Oct 30, 2023
rrousselGit
reviewed
Oct 30, 2023
rrousselGit
reviewed
Oct 30, 2023
rrousselGit
reviewed
Oct 30, 2023
rrousselGit
reviewed
Oct 30, 2023
rrousselGit
reviewed
Oct 30, 2023
rrousselGit
reviewed
Oct 30, 2023
|
Overall LGTM, with some minor API/readability issues |
kuhnroyal
force-pushed
the
feature/support-output-formats
branch
from
5c8c6b0 to
0325e3d
Compare
|
Should be good to go |
|
Great, thanks! |
oskar-zeinomahmalat-sonarsource
pushed a commit
to oskar-zeinomahmalat-sonarsource/dart_custom_lint
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intend to create another PR with the Dart JSON output as follow up, but splitting this in a separate PR for easier review.
No test changes, output stays the same for now.