Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BaseController.ok on non string content #423

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix BaseController.ok on non string content #423

merged 2 commits into from
Jan 30, 2025

Conversation

notaphplover
Copy link
Member

Description

Changed

  • Updated JsonContent with no generic.

Fixed

  • Updated BaseController.ok to no longer return text/plain responses when non string content is passed.

Related Issue

#420

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@notaphplover
refactor: update JsonResult with no generic
4ba64b2
@notaphplover
fix: update OkNegotiatedContentResult
93073c6 
update OkNegotiatedContentResult to rely on JsonContent when non string content is provided
@notaphplover notaphplover self-assigned this Jan 30, 2025
@notaphplover notaphplover merged commit f0eb0de into master Jan 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notaphplover notaphplover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@notaphplover