Update post_construct.md #1572
Open
Update post_construct.md #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be an inaccuracy in the Post Construct Decorator description (implementation seems correct)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be an inaccuracy in the Post Construct Decorator description (implementation seems correct)
Description
use()returned a string, no visible side-effect → updated toconsole.log()testMethod()was not discernibly different fromuse()→ updated to"Used ..."and"Tested ..."use()was not invoked → updated to invoke so that the log output would make more senseI did this via Github interface, so conventional commits didn't seem to be available
Related Issue
N/A
Motivation and Context
Clarity of use and intent.
How Has This Been Tested?
N/A
Types of changes
N/A
Checklist:
N/A