Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): include src to fix sourcemaps #1398

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chyzwar
Copy link
Contributor

@chyzwar chyzwar commented Nov 5, 2021

Include src folder in published package. This is require to fix source maps on webpack and simmilar.

I made this change few weeks ago but it was reversed #1366

@chyzwar
Copy link
Contributor Author

chyzwar commented Feb 9, 2022

pp_1    | WARNING in ../../node_modules/inversify/es/utils/js.js
app_1    | Module Warning (from ../../node_modules/source-map-loader/dist/cjs.js):
app_1    | Failed to parse source map from '/project/node_modules/inversify/src/utils/js.ts' file: Error: ENOENT: no such file or directory, open '/project/node_modules/inversify/src/utils/js.ts'
app_1    |  @ ../../node_modules/inversify/es/annotation/decorator_utils.js 3:0-53 26:24-46
app_1    |  @ ../../node_modules/inversify/es/inversify.js 6:0-69 6:0-69 21:0-56 21:0-56
app_1    |  @ ../../node_modules/@woodmac-lens/app/esm/enhancer.js 2:0-38 41:59-68 42:27-36
app_1    |  @ ../../node_modules/@woodmac-lens/app/esm/index.js 20:0-49 20:0-49
app_1    |  @ ./src/externals.ts 6:0-49 18:0-52 27:23-37 39:35-47
app_1    | 
app_1    | WARNING in ../../node_modules/inversify/es/utils/serialization.js
app_1    | Module Warning (from ../../node_modules/source-map-loader/dist/cjs.js):
app_1    | Failed to parse source map from '/project/node_modules/inversify/src/utils/serialization.ts' file: Error: ENOENT: no such file or directory, open '/project/node_modules/inversify/src/utils/serialization.ts'
app_1    |  @ ../../node_modules/inversify/es/inversify.js 23:0-69 23:0-69
app_1    |  @ ../../node_modules/@woodmac-lens/app/esm/enhancer.js 2:0-38 41:59-68 42:27-36
app_1    |  @ ../../node_modules/@woodmac-lens/app/esm/index.js 20:0-49 20:0-49
app_1    |  @ ./src/externals.ts 6:0-49 18:0-52 27:23-37 39:35-47
app_1    | 
app_1    | 53 warnings have detailed information that is not shown.
app_1    | Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.
app_1    | 

See example of error

Copy link

@jmfrancois jmfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have right on the repo but clearly way better option than #1412

The corresponding revert commit
b9442cc

but seems against maintainer opinion, the bug is still open after a year.
look at https://unpkg.com/browse/[email protected]/lib/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants