Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option ot mark the build item as complete if all tests passed #8061

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

martonmiklos
Copy link
Contributor

Fixes #6006

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 5abdd71
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66d7efc19e9dc200080853ed

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.80%. Comparing base (f144158) to head (5abdd71).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/forms/PartForms.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8061      +/-   ##
==========================================
- Coverage   83.87%   83.80%   -0.07%     
==========================================
  Files        1142     1143       +1     
  Lines       50979    51019      +40     
  Branches     1783     1785       +2     
==========================================
- Hits        42760    42758       -2     
- Misses       7760     7824      +64     
+ Partials      459      437      -22     
Flag Coverage Δ
backend 85.72% <100.00%> (+0.01%) ⬆️
pui 64.91% <85.71%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martonmiklos martonmiklos changed the title [WIP]Add option ot mark the build item as complete if all tests passed Add option ot mark the build item as complete if all tests passed Sep 4, 2024
@SchrodingersGat
Copy link
Member

@martonmiklos thanks for looking at this, and apologies for the delayed response.

Looking at the new model field implementation here, I think that it should be an option against the BuildOrder instance, rather than the Part instance.

@matmair @wolflu05 any thoughts or preferences here?

@martonmiklos
Copy link
Contributor Author

martonmiklos commented Sep 23, 2024

@martonmiklos thanks for looking at this, and apologies for the delayed response.

No worries.

Looking at the new model field implementation here, I think that it should be an option against the BuildOrder instance, rather than the Part instance.

@matmair @wolflu05 any thoughts or preferences here?

I see your point, but I would say both options could make sense. In my use case most of the products got packaged as the part of the last teststep so closing the build order when all units passed makes sense. Enabling the "autoclose" feature for each build order created would not makes too much sense in this case.

I am open to tailor this feature further by adding an "autoclose" option to the build orders dynamically (if it is not enabled at part level).

@SchrodingersGat
Copy link
Member

@martonmiklos I was envisioning a much "simpler" approach, where you can set the "default value" for the "auto close" option as a global setting, but then adjust on a per-build level as needed.

Having this as a "per part" option seems a bit messy (for lack of a better word) especially as most parts cannot be "built" (they are components, e.g. ) and so the option does not even make sense for them. At a bare minimum the option should be hidden for parts which are not "assemblies".

The issue here is that we do not have any other "dependent attributes" - the attributes such as "purcahsesable", "trackable" , "salable" (etc) are all independent of each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]Add option to being able to mark build outputs completed if all required tests are passed
2 participants