Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add RMA support #4488

Merged
merged 115 commits into from
Mar 28, 2023
Merged

[Feature] Add RMA support #4488

merged 115 commits into from
Mar 28, 2023

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Mar 14, 2023 •
edited
Loading

This PR adds support for "RMA" or "Return Order" functionality.

Initial implementation may be somewhat "bare bones" and need fleshing out in greater detail in subsequent PRs.

TODO

@SchrodingersGat
Adds ReturnOrder and ReturnOrderAttachment models
139170c
@SchrodingersGat
Adds new 'role' specific for return orders
2bddba4
@SchrodingersGat
Refactor total_price into a mixin
047e65c 
- Required for PurchaseOrder and SalesOrder
- May not be required for ReturnOrder (remains to be seen)
@SchrodingersGat
Adds API endpoints for ReturnOrder
ab1ed84 
- Add list endpoint
- Add detail endpoint
- Adds required serializer models
@SchrodingersGat
Adds basic "index" page for Return Order model
718ad03
@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders report Report/Label generation api Relates to the API labels Mar 14, 2023
@SchrodingersGat SchrodingersGat added this to the 0.11.0 milestone Mar 14, 2023
@SchrodingersGat
Add db migration for new "role"
260d38c
@SchrodingersGat
Add ContactList and ContactDetail API endpoints
ab5e5ca
@SchrodingersGat
Adds template and JS code for manipulation of contacts
095c4d5 
- Display a table
- Create / edit / delete
@SchrodingersGat
Splits order.js into multiple files
e70d013 
- Javascript files was becoming extremely large
- Hard to debug and find code
- Split into purchase_order / return_order / sales_order
@SchrodingersGat
Fix role name (change 'returns' to 'return_order')
e6e76c7 
- Similar to existing roles for purchase_order and sales_order
@SchrodingersGat
Adds detail page for ReturnOrder
9ae6160
@SchrodingersGat
URL cleanup
e870dae 
- Use <int:pk> instead of complex regex
@SchrodingersGat
More URL cleanup
7e43b69
@SchrodingersGat
Add "return orders" list to company detail page
ec03e0c
@SchrodingersGat
Break JS status codes into new javascript file
42dc979 
- Always difficult to track down where these are rendered
- Enough to warrant their own file now
@SchrodingersGat
Add ability to edit return order from detail page
bbde464
@SchrodingersGat
Database migrations
acd5dbc 
- Add new ReturnOrder modeles
- Add new 'contact' field to external orders
@SchrodingersGat
Adds "contact" to ReturnOrder
cd50428 
- Implement check to ensure that the selected "contact" matches the selected "company"
@SchrodingersGat
Adjust filters to limit contact options
aeca25c
@matmair
Copy link
Member

matmair commented Mar 14, 2023

Very intresting PR!

@SchrodingersGat SchrodingersGat mentioned this pull request Mar 28, 2023
Merged
@SchrodingersGat SchrodingersGat mentioned this pull request Mar 28, 2023
Merged
@SchrodingersGat SchrodingersGat merged commit 27aa16d into inventree:master Mar 28, 2023
@SchrodingersGat SchrodingersGat deleted the rma-order branch March 28, 2023 23:35
@matmair
Copy link
Member

matmair commented Mar 29, 2023

Nice!

@SchrodingersGat
Copy link
Member Author

@matmair already used it in anger. Seems to work well, I'm sure there'll be additional things to add.

I'll put up a blog post soon

This was referenced Mar 29, 2023
Merged
Merged
@mabroens
Copy link

Hi All, the RMA feature sounds great. any idea when it will be released?

Br Martijn

@matmair
Copy link
Member

matmair commented Apr 14, 2023

We do not give out release dates as the project is developed in spare time.

@matmair matmair mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmair matmair Awaiting requested review from matmair

Assignees
No one assigned
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders report Report/Label generation
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

[FR] RMA/ Repair Order function
3 participants
@SchrodingersGat @matmair @mabroens