Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: add subcommunity invitation request #1249

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Nov 18, 2024

❤️ Thank you for your contribution!

Close zenodo/zenodo-rdm#1061

Description

Please describe briefly your pull request.

Emails sent upon create, decline, create, accept

image

Expire

image


image

image

image

image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack carlinmack force-pushed the subcom-invitation branch 2 times, most recently from 47a0f75 to 80a6dd6 Compare November 20, 2024 14:54
refactor and fix bugs in sending emails
Copy link
Contributor

@jrcastro2 jrcastro2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer reviewed with @0einstein0! LGTU 🚀

Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit/comment for the email phrasing

delete unused file and add expiry to email
@slint slint merged commit afa3115 into inveniosoftware:master Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create subcommunity invitation request
3 participants