-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on Julia 1.7 #33
Fix on Julia 1.7 #33
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 97.69% 97.77% +0.08%
==========================================
Files 5 5
Lines 217 225 +8
==========================================
+ Hits 212 220 +8
Misses 5 5
Continue to review full report at Codecov.
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I don't know if you want to handle this but: In Julia 1.7, with this change: julia> ExprTools.name_of_type(Vararg)
ERROR: UndefRefError: access to undefined reference
Stacktrace:
[1] getproperty
@ ./Base.jl:42 [inlined]
[2] name_of_type(x::Core.TypeofVararg)
@ ExprTools ~/.julia/packages/ExprTools/fES3C/src/method.jl:184
[3] top-level scope
@ REPL[5]:1 In Julia 1.6, with or without this change:
|
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes #32 and #28
Vararg
on 1.7 is not a type any more.So it gets its own path through the code.
This does mean we actually generate nicer code with that.
(because it was easier to generate nicer code than workout how to generate code identical to what we had before).
But that also means we needed to put some branches in the tests where they do produce nicer code
This PR blocks fixing Nabla to work on Julia 1.7.
(though old versions of Nabla that are PreChainRules are not blocked by this. Including the version in production)