Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size limit support #691

Closed
wants to merge 11 commits into from
Closed

Size limit support #691

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
92b0e12
chore: add optional size.limit configuration option
JordanForeman Apr 26, 2022
7cc56a7
feat: add functional support for size.limit option
JordanForeman Apr 26, 2022
9be9f5b
chore: extract package loading to BuildUtils
JordanForeman Apr 28, 2022
2cb557d
chore: elevate package src loading to analysis layer
JordanForeman Apr 28, 2022
9d358bc
feat: enforce package-scoped size limit
JordanForeman Apr 28, 2022
6dcef85
chore: update documentation to reflect new feature
JordanForeman Apr 28, 2022
0541a25
fix: typeerrors in build
JordanForeman Apr 28, 2022
72e0b58
fix: circular dependency caused by using load-config
JordanForeman Apr 28, 2022
f1a7408
fix: JSDoc
JordanForeman Apr 28, 2022
42b4cfd
fix: enable size limits for lerna packages
JordanForeman Apr 29, 2022
abd4826
fix: loading config from PR/local path
JordanForeman Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions plugins/size/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,15 @@ export default class SizePlugin implements Plugin<SizeArgs> {
});
const header = args.css ? cssHeader : defaultHeader;

const underFailureThreshold = size &&
size.percent <= FAILURE_THRESHOLD ||
size.percent === Infinity;
const underSizeLimit = args.limit ? size.pr.js + size.pr.css <= args.limit : true;
const success = underFailureThreshold && underSizeLimit;

await reportResults(
name,
size.percent <= FAILURE_THRESHOLD || size.percent === Infinity,
success,
Boolean(args.comment),
table(
args.detailed
Expand All @@ -107,7 +113,7 @@ export default class SizePlugin implements Plugin<SizeArgs> {
createDiff();
}

if (size && size.percent > FAILURE_THRESHOLD && size.percent !== Infinity) {
if (!success) {
process.exit(1);
}
}
Expand Down
2 changes: 2 additions & 0 deletions plugins/size/src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ export interface SizeArgs {
ignore?: string[]
/** The registry to install packages from */
registry?: string
/** Size limit failure threshold */
limit?: number
JordanForeman marked this conversation as resolved.
Show resolved Hide resolved
/** Size Failure Threshold */
failureThreshold?: number
/** Run the plugin against merge base. (Will be slower due to additional build process) */
Expand Down