Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Goals of this PR 🎉
Carthage support has been added to CardParts.
Because Cocoapods is also supported and is responsible for generating the Xcode project and workspace, I changed the
.gitignore
to allow tracking of the Pod source code - which allows Carthage to build the project when another app specifies CardParts as a dependency. This creates some repo bloat but allows both dependency managers to co-exist.Additionally for Carthage to build, the Xcode workspace needed to share the CardParts scheme (CardParts.xcscheme) This file is found in the Pods subfolders.
Summary of changes:
How Has This Been Tested 🔍
github "JJ-Intuit/CardParts" ~> 2.21.2
carthage update --platform ios
Test Configuration 👾