[PB-3639]: fix/get existing customer #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sg-gs
requested changes
Feb 6, 2025
src/server.ts
Outdated
| const start = async (mongoTestClient?: MongoClient): Promise<FastifyInstance> => { | ||
| const start = async ( | ||
| mongoTestClient?: MongoClient, | ||
| mocksServices?: { |
There was a problem hiding this comment.
This a very bad idea. Tests are for covering the real codebase, you cannot mix both things. What you need to do here involves mechanisms like sinon's stub method, which will save you from editing the codebase to have tests working.
tests/src/mocks/index.ts
Outdated
| @@ -9,6 +9,16 @@ import { Tier } from '../../../src/core/users/MongoDBTiersRepository'; | |||
| const randomDataGenerator = new Chance(); | |||
|
|
|||
| export default function getMocks() { | |||
| const user = { | |||
There was a problem hiding this comment.
If you can use functions to instantiate mocks instead of having to create a const each time, that would be cleaner, easier to use and faster to work with. Example here where you can instantiate a user, by default it has as real as possible fields (using chance). It has of course things to improve, but it's far more scalable than this way of creating mocks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the uuid to get the existing user from our DB if it exists before creating a new one in Stripe when calling
POST /create-customer. Also, we get the user by uuid when payment invoices are completed to update it in the DB if needed.