-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respond to duke feedback #17
Conversation
✅ Deploy Preview for register-geoconnex-us ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
for more information, see https://pre-commit.ci
Suggest something aboiut how what you put in the namespace will be created if it does not already exist, and your identifiers will just be added to the existing namespace if it already exists. And maybe slightly more explicit language that
|
for more information, see https://pre-commit.ci
Responded to the feedback.
|
Remove marked from package.json please |
The page about the namespace creation should be a separate "step" from the uploading of the CSV. I suggest the implementation of stepper to better address the namespace specific requirements. Perhaps this is a first step where you either select the namespace from GitHub API populated list, or create a new one. Second step is uploading and formatting the CSV file |
for more information, see https://pre-commit.ci
@webb-ben when you get a moment would you mind letting me know what you think of the v-stepper change? It is not done yet, still have to make the validation code work in each tab and improve the submission tab. (Wanted to check with you before I went in too deep or if you want anything else) Thanks for recommending to use v-stepper. It looks nice and is a great way to split up the form semantically. (Also allows us to add extra background info without cramming the form) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still more work to be done on this but switching off for a bit to work on some other stuff since I am getting a bit stuck. @webb-ben if you have a moment these were the two issues I was preferring to.
Otherwise I will take a look at thisagain later
Since we do not have a logo that works with a dark background, should I just remove the dark mode toggle? I think dark mode is a nice quality of life improvement, but that being said, I can't find a way to make the logos look good on a dark background without adding a white border. Not sure what is best |
I think we can implement it in a future sprint if desired. No reason to be hung up on it right now |
for more information, see https://pre-commit.ci
Should be ready to review: Things I added:
Things I will add in a future PR:
Things I wasn't sure about:
|
for more information, see https://pre-commit.ci
Description