Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grecaptcha check when setting recaptcha submit callback #10477

Merged

Conversation

jimchamp
Copy link
Collaborator

Closes #

Technical

Testing

Screenshot

Stakeholders

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 17.29%. Comparing base (606faaf) to head (ae96a31).
Report is 422 commits behind head on master.

Files with missing lines Patch % Lines
openlibrary/plugins/openlibrary/js/signup.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10477      +/-   ##
==========================================
- Coverage   17.31%   17.29%   -0.02%     
==========================================
  Files          87       87              
  Lines        4835     4839       +4     
  Branches      856      858       +2     
==========================================
  Hits          837      837              
- Misses       3471     3473       +2     
- Partials      527      529       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini self-assigned this Feb 19, 2025
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on testing, and worked as expected.

@cdrini cdrini merged commit 491e75c into internetarchive:master Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants