Log Recaptcha errors in Sentry #10476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Priority: 1
cdrini
reviewed
Feb 19, 2025
Comment on lines
39
to
43
| if not data.get('success', False) and 'error-codes' in data: | ||
| from openlibrary.plugins.openlibrary.sentry import sentry | ||
|
|
||
| if sentry and sentry.enabled: | ||
| sentry.capture_message(f"Recaptcha Error: {data['error-codes']}") | ||
|
|
There was a problem hiding this comment.
logged exceptions are captured in sentry, so we should be able to do:
Suggested change
| if not data.get('success', False) and 'error-codes' in data: | |
| from openlibrary.plugins.openlibrary.sentry import sentry | |
| if sentry and sentry.enabled: | |
| sentry.capture_message(f"Recaptcha Error: {data['error-codes']}") | |
| if not data.get('success', False) and 'error-codes' in data: | |
| logging.getLogger("openlibrary").exception(f"Recaptcha Error: {data['error-codes']}") |
I believe.
jimchamp
force-pushed
the
10474/bug/handle-recaptcha-errors
branch
from
70fd537 to
d157c7e
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10474
Captures the
error-codesfield of any failing ReCaptcha verification in Sentry.Technical
Testing
Screenshot
Stakeholders