#10390/fix/single double quote breaking solr query

[tomrod10]

Closes #10390

Searching with an unmatched double quote ", causes the Solr query to be invalid/break.

On line 484 in ~/openlibrary/plugins/worksearch/schemes/works.py it looks like it escapes already escaped ". Therefore turning the string:
'Compilation Group for the \\"History of Modern China' into 'Compilation Group for the \\\\"History of Modern China'.

I edited the code on line 484 to only escape " if \\" is not in the ed_q string. Otherwise, either all " will be escaped if ed_q is not falsy, else the kwarg v will be set to *:*.

Technical

Testing

Added tests:

• ~/openlibrary/plugins/worksearch/schemes/tests/test_works.py

Manual testing:

• Searched words and phrases with a single or an odd count of "
• Checked that the query results in a 200 OK response

Screenshot

Stakeholders

@cdrini

[tomrod10]

The following tests are failing:

• openlibrary/plugins/worksearch/schemes/tests/test_works.py::test_process_user_query[Spaces after fields]
• openlibrary/plugins/worksearch/schemes/tests/test_works.py::test_process_user_query[Quotes]
• openlibrary/plugins/worksearch/schemes/tests/test_works.py::test_process_user_query[LCC: quotes preserved]

[tomrod10]

Probably will move my test to tests/test_works.py and delete tests/test_SearchScheme.py