-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Richer UI install for PWA on Chrome #10393
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10393 +/- ##
==========================================
- Coverage 17.43% 17.31% -0.13%
==========================================
Files 88 87 -1
Lines 4811 4835 +24
Branches 853 856 +3
==========================================
- Hits 839 837 -2
- Misses 3447 3471 +24
- Partials 525 527 +2 ☔ View full report in Codecov by Sentry. |
@RayBB, I've added the desktop screenshots to the .mockup file and referenced the same images in the manifest.json. However, I'm not sure how to test this locally. Could you please help me with that? |
Can you please provide a link to the guides you've tried following already and what part you're getting suck at? |
@RayBB I am sorry , it was a confusion. I've added the screenshots to .mockup as of now. |
I think storing them wow in the static folder is good! |
9f0b479
to
7350352
Compare
@RayBB works on desktop, couldnt test on mobile. Should I also update .mockup with the new screenshots as @cdrini mentioned here #8929 (comment) |
Yes please
…On Sun, Feb 2, 2025, 1:43 AM Ananya Sriramareddy Kaligal < ***@***.***> wrote:
@RayBB <https://github.com/RayBB> works on desktop, couldnt test on
mobile.
Should I also update .mockup with the new screenshots as @cdrini
<https://github.com/cdrini> mentioned here #8929 (comment)
<#8929 (comment)>
—
Reply to this email directly, view it on GitHub
<#10393 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHA5ANMCHYRE3D6QEG4WQT2NW5BTAVCNFSM6AAAAABWAC5LDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGI3DQMRTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@RayBB Done! updated both desktop and mobile screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RayBB Yes, I can do that |
@RayBB Changes made as requested. Is thsi good? |
Looks nice to me but I'll double check with staff this week! |
Closes #8929
DRAFT PR - will edit this once all the tasks are achieved.
Stakeholders
@RayBB