Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker installation #10373

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Update docker installation #10373

merged 2 commits into from
Jan 20, 2025

Conversation

mekarpeles
Copy link
Member

Closes #10276

Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One thing I'd add, and I don't think it matters much, is the that there is a built in table of contents, but I don't think many people seem to know about it: https://github.blog/changelog/2021-04-13-table-of-contents-support-in-markdown-files/

@mekarpeles mekarpeles merged commit 961f803 into master Jan 20, 2025
7 checks passed
@mekarpeles mekarpeles deleted the docker-installation branch January 20, 2025 23:05
ShilpThapak pushed a commit to ShilpThapak/openlibrary that referenced this pull request Jan 26, 2025
* Update docker installation

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing arm64 arch in docker manifest causing docker build to error out
2 participants