10223/refactor/delete unused functions from upstream accounts.py #10363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
These tests have been marked as expected to fail since this commit and I haven't removed them for preventing confusion later on. Here's a code snippet from the test_account.py I would suggest a separate issue be made for the removal of those tests in order to assert that these changes do not have any impact on those tests. |
3 tasks
mekarpeles
reviewed
Jan 24, 2025
| @@ -56,7 +55,7 @@ | |||
| RESULTS_PER_PAGE: Final = 25 | |||
|
|
|||
| # XXX: These need to be cleaned up | |||
| send_verification_email = accounts.send_verification_email | |||
| # send_verification_email = accounts.send_verification_email | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10223
refactor
Technical
This implementation removes some functions in the accounts.py that are not required anymore. These largely dealt with signing up users and verifying their email IDs. Since we have shifted these operations to the Internet Archive infrastructure, these are obsolete.
Also note that the tests made for all the functions related to accounts have been marked as expected to fail prior to these commits.
Testing
Screenshot
Stakeholders
@scottbarnes