Feature/query carousel editions #10362
Conversation
This makes more sense for browse-ish carousels
for more information, see https://pre-commit.ci
|
@cdrini can you review this |
|
@cdrini mentions this rebase effort may need to be re-aligned with the cached query carousel |
|
@Lokeshranjan8, can you update your original comment such that it explains the changes that you've made? It would also be helpful to know exactly what was required to merge #7295. Could you add these to the updated comment, as well? |
jimchamp
added
the
Needs: Submitter Input
|
(Note for testing we can create a dummy page with a librivox query carousel, eg something like @jimchamp notes that the client side code will likely need to be updated; up to you @jimchamp whether that makes sense as part of this PR or a separate issue/pr. |
There was a problem hiding this comment.
Hi, @Lokeshranjan8!
Since you did not update the PR, it's unclear to me if you are still interested in working on this.
If you are still working on this, please:
- Revert changes made to
QueryCarousel.htmland instead make the changes inRawQueryCarousel.html. - Update the PR, describing the work that you've done.
| @@ -1,4 +1,4 @@ | |||
| $def with(query, title=None, sort='new', key='', limit=20, search=False, has_fulltext_only=True, url=None, layout='carousel', use_cache=True) | |||
| $def with(query, title=None, sort='new', key='', limit=20, search=False, has_fulltext_only=True, url=None) | |||
There was a problem hiding this comment.
Changes to this file should be reverted. Instead, make changes in RawQueryCarousel.html.
Closes: #7252
Technical
Testing
Screenshot
Stakeholders