Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opposite direction arrow button for Omnibar #10315

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Craig-Rosario
Copy link
Contributor

Closes #10240

Opposite direction arrow button for Omnibar:

  1. Add's new arrow in HTML, CSS, and JS with functionality.
  2. Avoid clipping of the first element due to the arrows.
  3. Renamed arrows to "nav-arrow-left" and "nav-arrow-right" to avoid confusion in the future.

Technical

Testing

1)Go to any book page (eg. https://openlibrary.org/works/OL69166W/Italian_journeys)
2)Resize the screen and see the arrow only for one direction

Screenshot/Video

Video of implementation:

new.arrow.mp4

Screenshot:
image

Stakeholders

@cdrini

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 17.57%. Comparing base (3025f5d) to head (cbc8b8f).
Report is 141 commits behind head on master.

Files with missing lines Patch % Lines
...ns/openlibrary/js/edition-nav-bar/EditionNavBar.js 0.00% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10315      +/-   ##
==========================================
+ Coverage   17.44%   17.57%   +0.12%     
==========================================
  Files          89       88       -1     
  Lines        4792     4775      -17     
  Branches      848      849       +1     
==========================================
+ Hits          836      839       +3     
+ Misses       3436     3415      -21     
- Partials      520      521       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opposite direction arrow button for Omnibar
3 participants