MDL-55136 data_object: fix param handling in fetch_all_helper

interlegis · Jul 6, 2016 · a106fb8 · a106fb8
1 parent ac8d6cf
commit a106fb8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/completion/data_object.php b/completion/data_object.php
@@ -213,6 +213,7 @@ public static function fetch_all_helper($table, $classname, $params) {
 
         $wheresql = array();
 
+        $dbparams = array();
         foreach ($params as $var=>$value) {
             if (!in_array($var, $instance->required_fields) and !array_key_exists($var, $instance->optional_fields)) {
                 continue;
@@ -221,7 +222,7 @@ public static function fetch_all_helper($table, $classname, $params) {
                 $wheresql[] = " $var IS NULL ";
             } else {
                 $wheresql[] = " $var = ? ";
-                $params[] = $value;
+                $dbparams[] = $value;
             }
         }
 
@@ -232,7 +233,7 @@ public static function fetch_all_helper($table, $classname, $params) {
         }
 
         global $DB;
-        if ($datas = $DB->get_records_select($table, $wheresql, $params)) {
+        if ($datas = $DB->get_records_select($table, $wheresql, $dbparams)) {
 
             $result = array();
             foreach($datas as $data) {