MDL-47232 completion: Completed and failed activities count as completed

interlegis · Jan 8, 2015 · 2cc8d56 · 2cc8d56
1 parent 2e02eab
commit 2cc8d56
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/completion/criteria/completion_criteria_activity.php b/completion/criteria/completion_criteria_activity.php
@@ -147,7 +147,7 @@ public function review($completion, $mark = true) {
         $data = $info->get_data($cm, false, $completion->userid);
 
         // If the activity is complete
-        if (in_array($data->completionstate, array(COMPLETION_COMPLETE, COMPLETION_COMPLETE_PASS))) {
+        if (in_array($data->completionstate, array(COMPLETION_COMPLETE, COMPLETION_COMPLETE_PASS, COMPLETION_COMPLETE_FAIL))) {
             if ($mark) {
                 $completion->mark_complete();
             }
@@ -229,6 +229,7 @@ public function cron() {
             AND (
                 mc.completionstate = '.COMPLETION_COMPLETE.'
              OR mc.completionstate = '.COMPLETION_COMPLETE_PASS.'
+             OR mc.completionstate = '.COMPLETION_COMPLETE_FAIL.'
                 )
         ';