-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: treat resume as start if sessions lost, trigger resume if needed #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extension builds preview
|
just to make simple build pass on windows where i don't have dev setup lol
…ound to terminate
sidvishnoi
commented
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test-e2e
sidvishnoi
commented
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test-e2e
fix was tested on Windows for Firefox/Chrome/Edge:
also this is a fix for #841 on Firefox/Chrome/Edge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: background
Improvements or additions to extension background script
area: content
Improvements or additions to extension content script
area: shared
Changes to shared libraries and utilities
area: tests
Improvements or additions to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #841
Closes #871
More context: #871 (comment)
Changes proposed in this pull request
REQUEST_RESUME_MONETIZATION
message to content script to call resume in content, which will trigger the start.background.start()
.Testing
See #871 (comment) for how to reproduce. The bf-cache one is covered by E2E tests, but sleep one requires manual testing. I've tested following scenarios (with computer sent to sleep around 60-70 times 😆):