-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): wallet address response with tenant id #2986
Merged
njlie
merged 24 commits into
2893-multi-tenant-rafiki
from
nl/2925/wallet-address-response-with-tenantid
Sep 30, 2024
Merged
feat(backend): wallet address response with tenant id #2986
njlie
merged 24 commits into
2893-multi-tenant-rafiki
from
nl/2925/wallet-address-response-with-tenantid
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
Testing related
pkg: backend
Changes in the backend package.
pkg: frontend
Changes in the frontend package.
type: source
Changes business logic
pkg: auth
Changes in the GNAP auth package.
pkg: mock-ase
pkg: mock-account-service-lib
labels
Sep 17, 2024
njlie
force-pushed
the
nl/2925/wallet-address-response-with-tenantid
branch
from
September 18, 2024 17:04
910b74f
to
2648864
Compare
github-actions
bot
removed
type: tests
Testing related
pkg: mock-ase
pkg: mock-account-service-lib
labels
Sep 18, 2024
golobitch
reviewed
Sep 22, 2024
@@ -64,6 +64,7 @@ export const getTenant: QueryResolvers<ApolloContext>['tenant'] = async ( | |||
} | |||
}) | |||
} | |||
console.log('TENANT: ', tenant) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can probably be removed now, yes?
golobitch
reviewed
Sep 22, 2024
packages/backend/src/index.ts
Outdated
@@ -758,6 +758,8 @@ export const start = async ( | |||
`Auto-peering server listening on ${config.autoPeeringServerPort}` | |||
) | |||
} | |||
|
|||
await app.createOperatorIdentity() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already created few lines above. Line number 745.
njlie
force-pushed
the
nl/2925/wallet-address-response-with-tenantid
branch
from
September 24, 2024 20:03
2648864
to
b840594
Compare
…ed, permissioned admin UI pages
njlie
force-pushed
the
nl/2925/wallet-address-response-with-tenantid
branch
from
September 24, 2024 20:37
b840594
to
d7f2883
Compare
njlie
requested review from
golobitch,
mkurapov,
sabineschaller and
sanducb
September 26, 2024 23:46
golobitch
approved these changes
Sep 27, 2024
This was referenced Sep 30, 2024
This was
linked to
issues
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg: auth
Changes in the GNAP auth package.
pkg: backend
Changes in the backend package.
pkg: frontend
Changes in the frontend package.
type: source
Changes business logic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
tenantId
path parameter to Open Payments routes, as well as to incoming payments & wallet address responses.Context
Fixes #2926 and #2925.
Checklist
fixes #number
user-docs
label (if necessary)