Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): wallet address response with tenant id #2986

Merged
merged 24 commits into from
Sep 30, 2024
Merged

feat(backend): wallet address response with tenant id #2986

merged 24 commits into from
Sep 30, 2024

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Sep 17, 2024 •
edited
Loading

Changes proposed in this pull request

  • Add a tenantId path parameter to Open Payments routes, as well as to incoming payments & wallet address responses.

Context

Fixes #2926 and #2925.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: auth Changes in the GNAP auth package. pkg: mock-ase pkg: mock-account-service-lib labels Sep 17, 2024
@njlie njlie force-pushed the nl/2925/wallet-address-response-with-tenantid branch from 910b74f to 2648864 Compare September 18, 2024 17:04
golobitch
golobitch reviewed Sep 22, 2024
View reviewed changes
packages/backend/src/graphql/resolvers/tenant.ts Outdated
@@ -64,6 +64,7 @@ export const getTenant: QueryResolvers<ApolloContext>['tenant'] = async (
}
})
}
console.log('TENANT: ', tenant)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can probably be removed now, yes?

golobitch
golobitch reviewed Sep 22, 2024
View reviewed changes
packages/backend/src/index.ts Outdated
@@ -758,6 +758,8 @@ export const start = async (
`Auto-peering server listening on ${config.autoPeeringServerPort}`
)
}

await app.createOperatorIdentity()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already created few lines above. Line number 745.

@njlie njlie force-pushed the nl/2925/wallet-address-response-with-tenantid branch from 2648864 to b840594 Compare September 24, 2024 20:03
@njlie njlie force-pushed the nl/2925/wallet-address-response-with-tenantid branch from b840594 to d7f2883 Compare September 24, 2024 20:37
@njlie njlie marked this pull request as ready for review September 26, 2024 23:46
@njlie njlie merged commit 3ab716c into 2893-multi-tenant-rafiki Sep 30, 2024
14 of 26 checks passed
@njlie njlie deleted the nl/2925/wallet-address-response-with-tenantid branch September 30, 2024 20:43
This was referenced Sep 30, 2024
Closed
Closed
This was linked to issues Oct 18, 2024
Update WalletAddress Response to include tenantId in path #2925
Closed
Add tenantId to OP paths #2926
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golobitch golobitch golobitch approved these changes

@mkurapov mkurapov Awaiting requested review from mkurapov

@sabineschaller sabineschaller Awaiting requested review from sabineschaller

@sanducb sanducb Awaiting requested review from sanducb

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tenantId to OP paths Update WalletAddress Response to include tenantId in path
3 participants
@njlie @golobitch @sanducb