Add missing docs #589
Closed
Add missing docs #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
commented
Jan 22, 2020
| @@ -99,7 +114,23 @@ where | |||
| .apply_rate_limits(request.from.clone(), request.prepare.amount()) | |||
| .await | |||
| { | |||
| Ok(_) => next.handle_request(request).await, | |||
| Ok(_) => { | |||
There was a problem hiding this comment.
This was a bug I introduced in the base PR
There was a problem hiding this comment.
👍Is this tested somewhere?
dora-gt
requested changes
Jan 23, 2020
There was a problem hiding this comment.
Some minor typos should be fixed but overall really nice work, and I left some comments also.
Regarding the comments on Stream, it will be nice to have reviews from @emschwartz
| @@ -8,9 +8,17 @@ | |||
| [](https://crates.io/crates/interledger) | |||
| [](https://docs.rs/interledger) | |||
| [](https://circleci.com/gh/interledger-rs/interledger-rs) | |||
|  | |||
|  | |||
|  | |||
There was a problem hiding this comment.
This looks like Rust itself is stable (passing CI or something). What about this?
|
Closing in favor of new stacked PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled against #585 .
Adds detailed docs for most things which were missing docs in the repo.
(CI is failing due to type length limit from #585, this is on my TODO list for the base)