Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javadoc and reenable maven-javadoc-plugin failOnError #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rizwantanoli
Copy link

Made fixes pertaining to #1

Copy link

@iroskam iroskam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite whole files being marked as changed I only see the removal of some Javadoc return annotations. It is beneficial to have the return types stated in the Javadoc.

Did you change line endings? What other reason would git mark the whole file as changed?

@sappenin
Copy link
Collaborator

Hi @rizwantanoli This project is currently dormant. All future work should probably happen in the Hyperledger Quilt project, although we don't yet have much around an ILP Connector.

I'm working on something in my own repo (https://github.com/sappenin/java-ilpv4-connector) if you want to follow along, but it's not yet ready for primetime. Once I get things a bit more stable, I'm hoping to push out an LPI Plugin project (follow that here: https://github.com/sappenin/java-ilp-plugin), as well as implementation of Routing and other ILP RFCs related to a Connector. Stay-tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants