Merge pull request #969 from sander2/fix/bounds

fix: liquidate_incentive_reserved_factor bounds
interlay · Mar 14, 2023 · 3508b60 · 3508b60
2 parents 6b153a5 + f2b6622
commit 3508b60
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/crates/loans/src/lib.rs b/crates/loans/src/lib.rs
@@ -673,8 +673,7 @@ pub mod pallet {
                 Error::<T>::InvalidFactor,
             );
             ensure!(
-                market.liquidate_incentive_reserved_factor > Ratio::zero()
-                    && market.liquidate_incentive_reserved_factor < Ratio::one(),
+                market.liquidate_incentive_reserved_factor < Ratio::one(),
                 Error::<T>::InvalidFactor,
             );
             ensure!(market.supply_cap > Zero::zero(), Error::<T>::InvalidSupplyCap,);
@@ -814,6 +813,10 @@ pub mod pallet {
                 reserve_factor > Ratio::zero() && reserve_factor < Ratio::one(),
                 Error::<T>::InvalidFactor
             );
+            ensure!(
+                market.liquidate_incentive_reserved_factor < Ratio::one(),
+                Error::<T>::InvalidFactor,
+            );
             ensure!(supply_cap > Zero::zero(), Error::<T>::InvalidSupplyCap);
 
             let market = Self::mutate_market(asset_id, |stored_market| {