fix(config-plugin): Improve plugin to support swift #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nasseratic
reviewed
Apr 22, 2025
Comment on lines
+100
to
+131
| stringContents = isSwift | ||
| ? mergeContents({ | ||
| src: stringContents, | ||
| newSrc: 'import intercom_react_native.IntercomModule', | ||
| comment: '//', | ||
| tag: 'Intercom header', | ||
| anchor: /import Expo/, | ||
| offset: 1, | ||
| }).contents | ||
| : addObjcImports(stringContents, ['<IntercomModule.h>']); | ||
|
|
||
| // Remove previous code | ||
| stringContents = stringContents.replace( | ||
| /\s*\[IntercomModule initialize:@"(.*)" withAppId:@"(.*)"];/g, | ||
| '' | ||
| ); | ||
|
|
||
| stringContents = insertContentsInsideObjcFunctionBlock( | ||
| stringContents, | ||
| 'application didFinishLaunchingWithOptions:', | ||
| `[IntercomModule initialize:@"${props.iosApiKey}" withAppId:@"${props.appId}"];`, | ||
| { position: 'tailBeforeLastReturn' } | ||
| ); | ||
| stringContents = stringContents | ||
| .replace( | ||
| /\s*\[IntercomModule initialize:@"(.*)" withAppId:@"(.*)"];/g, | ||
| '' | ||
| ) | ||
| .replace(/\s*IntercomModule\.initialize\((.*), withAppId: (.*)\)/g, ''); | ||
|
|
||
| stringContents = isSwift | ||
| ? insertContentsInsideSwiftFunctionBlock( | ||
| stringContents, | ||
| 'application(_:didFinishLaunchingWithOptions:)', | ||
| `IntercomModule.initialize("${props.iosApiKey}", withAppId: "${props.appId}")`, | ||
| { position: 'tailBeforeLastReturn' } | ||
| ) | ||
| : insertContentsInsideObjcFunctionBlock( | ||
| stringContents, | ||
| 'application didFinishLaunchingWithOptions:', | ||
| `[IntercomModule initialize:@"${props.iosApiKey}" withAppId:@"${props.appId}"];`, | ||
| { position: 'tailBeforeLastReturn' } | ||
| ); |
There was a problem hiding this comment.
artistic choice ,but I would have a big if-else instead, so it's easier to see what is for Swift and what is for objc :D
...
} else {
...
}
|
@Titozzz Thanks a lot for the PR, hope the intercome team will merge this soon :) |
|
@Br1an-Boyle @liutingdu can you review this pr ? it is almost time for sdk 53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#276 is a good start but it's not enough.