-
Notifications
You must be signed in to change notification settings - Fork 1
Generate unstable SDK alongside v2.11 #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,60 @@ | |||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattblank11 none of the Custom Channel references need to go in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eclairemoy You shouldn't need to add anything else here - this file just overwrites certain parts of the unstable spec so that our generator can parse it properly. Anything added to this file was basically generating an error when we tried to generate your SDK without this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it may happening because we added them in openapi-overrides.yml
? If yes, should we remove/move them from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@auroralimin can you clarify the question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asked to add Custom Channel references in openapi-overrides: https://github.com/intercom/Intercom-OpenAPI/blob/main/fern/openapi-overrides.yml#L445
So I'm wondering if we don't need to add here because it is already added there. And/or if we should move the reference from there (either because is not necessary or because we could prioritise adding here only and not there, given that we do not want the SDK to implement these in the version 2.11).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, thanks for clarifying! You should be safe to remove from openapi-overrides
since we're not actually implementing the methods there. Let's move to unstable-api-overrides
!
Build is failing for Java and TS, is this related with the overwrites you did? |
I'll work on this before we chat! |
This PR allows Intercom to generate the
unstable
SDK alongside the stable SDK (v2.11
).To use the unstable endpoints, you can call:
You'll also notice that intellisense is aware of the request body in the unstable version