Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend synchronous DELETE requests return 204 #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

keithamus
Copy link
Contributor

I feel like we've reached enough of a consensus in #15 to attempt to PR a change, so this fixes #15.

Wording has been changed to suggest all responses should provide the latest copy of the data, further suggesting that (synchronous) DELETEs should return a 204 No Content.

@keithamus keithamus mentioned this pull request Jul 24, 2014
@rikvanmechelen
Copy link

I was the original creator of #15
So i am totally for the change. I followed the discussion in #15 and agree with it as well.
However, since this is a guide, it should leave both possibilities open, and include the reasoning of why one might want to chose a 204 above a 200 for a delete.

@keithamus
Copy link
Contributor Author

I think by virtue of it being a guide, it has a huge caveat emptor label over everything anyway. My personal feeling about this is that it should be prescriptive (and it all pretty much is so far), because leaving stuff open to interpretation means varying qualities of implementation.

@geemus
Copy link
Member

geemus commented Jul 24, 2014

I would also prefer a single prescriptive option, wherever possible. I think the exceptional case would be synchronous vs asynchronous. That said, one of my colleagues is pulling on a few extra threads in #15 that I'd like to continue discussing a bit more before we decide which possibility we think is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why no 204?
3 participants