Merge pull request #10 from nanliu/pluginsync

Update from Intelsdi-x pluginsync 0.1.5

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,34 @@
+<!--
+Thanks for filing an issue! Before hitting the button, give this a read.
+
+If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
+
+If you suspect your issue is a bug, please add as much context as you can using the template below. If it is not a bug, remove any sections you don't need and explain how we can help.
+
+As a basic rule, if you cannot provide enough information to continue addressing the issue within 7 days, a maintainer will close it. We will, however, reopen it if you later provide the information. Thanks again.
+-->
+
+**Snap version** (use `snapctl -v`):
+
+**Environment**:
+- **Cloud provider or hardware configuration**:
+- **OS** (e.g. from /etc/os-release):
+- **Kernel** (e.g. `uname -a`):
+- **Relevant tools** (e.g. plugins used with Snap):
+- **Others** (e.g. deploying with Ansible):
+
+
+**What happened**:
+
+
+**What you expected to happen**:
+
+
+**Steps to reproduce it** (as minimally and precisely as possible):
+
+1. 
+2. 
+3. 
+
+
+**Anything else do we need to know** (e.g. issue happens only occasionally):

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,21 @@
+<!--
+If this is a bug fix, make sure your description includes "fixes #xxxx", or
+"closes #xxxx"
+
+Please provide the following information:
+-->
+Fixes #
+
+Summary of changes:
+-
+-
+-
+
+How to verify it:
+-
+
+Testing done:
+-
+
+A picture of a snapping turtle (not required but encouraged):
+-

.gitignore

@@ -0,0 +1,41 @@
+# File managed by pluginsync
+#
+# NOTE: please commit OS/Editor specific settings in your .gitignore_global
+# .idea
+# .DS_Store
+#
+# Compiled Object files, Static and Dynamic libs (Shared Objects)
+*.o
+*.a
+*.so
+
+# Folders
+_obj
+_test
+
+# Architecture specific extensions/prefixes
+*.[568vq]
+[568vq].out
+
+*.cgo1.go
+*.cgo2.c
+_cgo_defun.c
+_cgo_gotypes.go
+_cgo_export.*
+
+_testmain.go
+
+*.exe
+*.test
+*.prof
+
+# Output of the go coverage tool
+*.out
+profile.cov
+
+# we don't vendor godep _workspace
+**/Godeps/_workspace/**
+vendor/
+
+# ignore build artifacts
+build/

.pluginsync.yml

@@ -0,0 +1,17 @@
+pluginsync_config: '0.1.5'
+managed_files:
+- .github
+- .github/ISSUE_TEMPLATE.md
+- .github/PULL_REQUEST_TEMPLATE.md
+- .gitignore
+- .pluginsync.yml
+- .travis.yml
+- CONTRIBUTING.md
+- LICENSE
+- Makefile
+- scripts
+- scripts/build.sh
+- scripts/common.sh
+- scripts/deps.sh
+- scripts/pre_deploy.sh
+- scripts/test.sh

.sync.yml

@@ -0,0 +1,12 @@
+.travis.yml:
+  deploy:
+    access_key_id: AKIAINMB43VSSPFZISAA
+    secret_access_key:
+      secure: ujIUxXac0/bXKPpcVKpoq0dWTRY4f2fTrZoaoMXwRt3JLK62BKAKvfqwAXa0OQhmLBLGblTsNWx4OgIV6iNiaQdZcqU6QkFNOHxWidq/GPlimRXfghZf0YU384kz0WOVTPWCgzTszKmjUve55dPCL8nsNKJI+TYsIAAmknld/hO+10tFjE0lMPb9MKz22J2rByWZoiXS7j254kfXBnWQZ/A4GR6gXoxFqUB8ESt5XVKcU3UoeYhDlSL62NcnmC6VRaFvGSw1ZHHbg0gv9z+bSxtZRARNWUKqeNraLBReJlHXi1NenWNKln2sIoV7o0W8WJCQMv5TVuPH94KHi5VG8ndlm35bQpjCcoZ2bx3CAkO+eFqnp73P9XG+MYFwPyst/PTKc0p4RrF6H0Lwnn9PHxTKnjMaK7YvBnCaeAJPSdNAPO0/VBwXCXKTg9xUFnmf1N3oZvI11WAfoGOrM32govVWR32cSp61K306hsUK2HQTFCsbqAAMRefyIo4t66C9+fv5hlj2Ajv7b865YkNGrNi+YevxVQtVgyrtazuqMYykFq+lLRGLkLp65K22Uf4WMuicAtJTi3Z57NRAtsUS/6zS6HX7Ww9mpdAE5RU/TeC7NKdMxQD3ZIBwg/jKFGGNPT4K3+3MWyNdyxxE/oPAWe3C6gHBBu5Cf2no7zhdB24=
+    api_key:
+      secure: cRaum5asJpZsKaOq0wPWGNMuQipJ8ga20pRK19ZwvYXfSXZnEl8fEJFlYNZQp5Ni93cqzW45x4j7qxv+LXDMkOQckKKKFRbfJQseHtCg8XSgG8OTURwwsICMK4GOXmARBKOBvXRzbiMrjVDhQCN5HXJcHnd6W98FkQymQ52xIlBkSknlpPkRiJC++GLksbZZ788wShTmuJHQMhnmBVmz41W5nc8fi+eNtPvkj98aMd2WSjbICv5ogZ3k0/Yztgeh9XDPqFlX+r2kYpy+8uLNhy9wBw4B1alXLAbgF1ml0bWVjEsIUGnYjRXAkxMr3+Rwdo/afhKgeav9kvjKd7Ihh3+lKEDYE6P6ToMkXjHvhzve87NFKNfogaGjRYDbZNxgLss/HkCW+9ghJjAwppT5oFfwxYC184YgpOcnEwH7gHWFcauDeKdGRUvt+TncbOigokUStcBVTHsoQnmECaXUw6XK2QRNx1H4xLhark2YQI9LbYfqgYtX1GS1JBzwB11MrANwS2e0+5GKqdJ/I5A9qA/8q24a5pr2fB6Z9/zV74gpTR7JTMcJTCoRVCm2QRYTSaoA83dR+jTDkDDTN4sgx9EK4YgkqoIdDUH4CsKQXcf+k4hlRwIzMymS5K3wTm7+ZF7Muy1XjoF9nlQR2EwMW7U2rWt/+PfWVZvMC8mlKn4=
+scripts/deps.sh:
+  packages:
+    - github.com/smartystreets/goconvey # NOTE: this should be moved to godep/glide
+    - github.com/stretchr/testify/mock
+    - github.com/gorilla/mux

.travis.yml

@@ -1,23 +1,69 @@
-sudo: required
+# File managed by pluginsync
+sudo: false
 language: go
 go:
-- 1.5.4
-- 1.6.2
-before_install:
-- go get github.com/tools/godep
-- if [ ! -d $SNAP_PLUGIN_SOURCE ]; then mkdir -p $HOME/gopath/src/github.com/intelsdi-x; ln -s $TRAVIS_BUILD_DIR $SNAP_PLUGIN_SOURCE; fi # CI for forks not from intelsdi-x
+- 1.6.3
+- 1.7.1
 env:
   global:
-    - SNAP_PLUGIN_SOURCE=/home/travis/gopath/src/github.com/intelsdi-x/snap-plugin-collector-cinder
+  - ORG_PATH=/home/travis/gopath/src/github.com/intelsdi-x
+  - SNAP_PLUGIN_SOURCE=/home/travis/gopath/src/github.com/${TRAVIS_REPO_SLUG}
   matrix:
-    - TEST=unit
+  - TEST_TYPE=small
+  - TEST_TYPE=build
+matrix:
+  exclude:
+  - go: 1.6.3
+    env: TEST_TYPE=build
+before_install:
+- "[[ -d $SNAP_PLUGIN_SOURCE ]] || mkdir -p $ORG_PATH && ln -s $TRAVIS_BUILD_DIR $SNAP_PLUGIN_SOURCE"
 install:
-- export TMPDIR=$HOME/tmp
-- mkdir -p $TMPDIR
-- cd $SNAP_PLUGIN_SOURCE # change dir into source
+- cd $SNAP_PLUGIN_SOURCE
 - make deps
 script:
-- make check TEST=$TEST 2>&1 # Run test suite
+- make check 2>&1
 notifications:
+  email: false
   slack:
     secure: VkbZLIc2RH8yf3PtIAxUNPdAu3rQQ7yQx0GcK124JhbEnZGaHyK615V0rbG7HcVmYKGPdB0cXqZiLBDKGqGKb2zR1NepOe1nF03jxGSpPq8jIFeEXSJGEYGL34ScDzZZGuG6qwbjFcXiW5lqn6t8igzp7v2+URYBaZo5ktCS2xY=
+before_deploy:
+- "./scripts/pre_deploy.sh"
+deploy:
+- provider: s3
+  access_key_id: AKIAINMB43VSSPFZISAA
+  secret_access_key:
+    secure: ujIUxXac0/bXKPpcVKpoq0dWTRY4f2fTrZoaoMXwRt3JLK62BKAKvfqwAXa0OQhmLBLGblTsNWx4OgIV6iNiaQdZcqU6QkFNOHxWidq/GPlimRXfghZf0YU384kz0WOVTPWCgzTszKmjUve55dPCL8nsNKJI+TYsIAAmknld/hO+10tFjE0lMPb9MKz22J2rByWZoiXS7j254kfXBnWQZ/A4GR6gXoxFqUB8ESt5XVKcU3UoeYhDlSL62NcnmC6VRaFvGSw1ZHHbg0gv9z+bSxtZRARNWUKqeNraLBReJlHXi1NenWNKln2sIoV7o0W8WJCQMv5TVuPH94KHi5VG8ndlm35bQpjCcoZ2bx3CAkO+eFqnp73P9XG+MYFwPyst/PTKc0p4RrF6H0Lwnn9PHxTKnjMaK7YvBnCaeAJPSdNAPO0/VBwXCXKTg9xUFnmf1N3oZvI11WAfoGOrM32govVWR32cSp61K306hsUK2HQTFCsbqAAMRefyIo4t66C9+fv5hlj2Ajv7b865YkNGrNi+YevxVQtVgyrtazuqMYykFq+lLRGLkLp65K22Uf4WMuicAtJTi3Z57NRAtsUS/6zS6HX7Ww9mpdAE5RU/TeC7NKdMxQD3ZIBwg/jKFGGNPT4K3+3MWyNdyxxE/oPAWe3C6gHBBu5Cf2no7zhdB24=
+  bucket: snap.ci.snap-telemetry.io
+  region: us-west-2
+  skip_cleanup: true
+  local-dir: s3
+  upload-dir: plugins
+  acl: public_read
+  on:
+    repo: intelsdi-x/snap-plugin-collector-cinder
+    branch: master
+    condition: $TEST_TYPE = "build" && $TRAVIS_GO_VERSION = "1.7.1"
+- provider: s3
+  access_key_id: AKIAINMB43VSSPFZISAA
+  secret_access_key:
+    secure: ujIUxXac0/bXKPpcVKpoq0dWTRY4f2fTrZoaoMXwRt3JLK62BKAKvfqwAXa0OQhmLBLGblTsNWx4OgIV6iNiaQdZcqU6QkFNOHxWidq/GPlimRXfghZf0YU384kz0WOVTPWCgzTszKmjUve55dPCL8nsNKJI+TYsIAAmknld/hO+10tFjE0lMPb9MKz22J2rByWZoiXS7j254kfXBnWQZ/A4GR6gXoxFqUB8ESt5XVKcU3UoeYhDlSL62NcnmC6VRaFvGSw1ZHHbg0gv9z+bSxtZRARNWUKqeNraLBReJlHXi1NenWNKln2sIoV7o0W8WJCQMv5TVuPH94KHi5VG8ndlm35bQpjCcoZ2bx3CAkO+eFqnp73P9XG+MYFwPyst/PTKc0p4RrF6H0Lwnn9PHxTKnjMaK7YvBnCaeAJPSdNAPO0/VBwXCXKTg9xUFnmf1N3oZvI11WAfoGOrM32govVWR32cSp61K306hsUK2HQTFCsbqAAMRefyIo4t66C9+fv5hlj2Ajv7b865YkNGrNi+YevxVQtVgyrtazuqMYykFq+lLRGLkLp65K22Uf4WMuicAtJTi3Z57NRAtsUS/6zS6HX7Ww9mpdAE5RU/TeC7NKdMxQD3ZIBwg/jKFGGNPT4K3+3MWyNdyxxE/oPAWe3C6gHBBu5Cf2no7zhdB24=
+  bucket: snap.ci.snap-telemetry.io
+  region: us-west-2
+  skip_cleanup: true
+  local-dir: s3
+  upload-dir: plugins
+  acl: public_read
+  on:
+    repo: intelsdi-x/snap-plugin-collector-cinder
+    tags: true
+    condition: $TEST_TYPE = "build" && $TRAVIS_GO_VERSION = "1.7.1"
+- provider: releases
+  api_key:
+    secure: cRaum5asJpZsKaOq0wPWGNMuQipJ8ga20pRK19ZwvYXfSXZnEl8fEJFlYNZQp5Ni93cqzW45x4j7qxv+LXDMkOQckKKKFRbfJQseHtCg8XSgG8OTURwwsICMK4GOXmARBKOBvXRzbiMrjVDhQCN5HXJcHnd6W98FkQymQ52xIlBkSknlpPkRiJC++GLksbZZ788wShTmuJHQMhnmBVmz41W5nc8fi+eNtPvkj98aMd2WSjbICv5ogZ3k0/Yztgeh9XDPqFlX+r2kYpy+8uLNhy9wBw4B1alXLAbgF1ml0bWVjEsIUGnYjRXAkxMr3+Rwdo/afhKgeav9kvjKd7Ihh3+lKEDYE6P6ToMkXjHvhzve87NFKNfogaGjRYDbZNxgLss/HkCW+9ghJjAwppT5oFfwxYC184YgpOcnEwH7gHWFcauDeKdGRUvt+TncbOigokUStcBVTHsoQnmECaXUw6XK2QRNx1H4xLhark2YQI9LbYfqgYtX1GS1JBzwB11MrANwS2e0+5GKqdJ/I5A9qA/8q24a5pr2fB6Z9/zV74gpTR7JTMcJTCoRVCm2QRYTSaoA83dR+jTDkDDTN4sgx9EK4YgkqoIdDUH4CsKQXcf+k4hlRwIzMymS5K3wTm7+ZF7Muy1XjoF9nlQR2EwMW7U2rWt/+PfWVZvMC8mlKn4=
+  file:
+    - release/snap-plugin-collector-cinder_linux_x86_64
+  skip_cleanup: true
+  on:
+    repo: intelsdi-x/snap-plugin-collector-cinder
+    tags: true
+    condition: $TEST_TYPE = "build" && $TRAVIS_GO_VERSION = "1.7.1"

CONTRIBUTING.md

@@ -1,4 +1,4 @@
-# snap collector plugin - cinder
+# snap plugin collector cinder
 
 1. [Contributing Code](#contributing-code)
 2. [Contributing Examples](#contributing-examples)
@@ -11,17 +11,17 @@ This repository has dedicated developers from Intel working on updates. The most
 **_IMPORTANT_**: We encourage contributions to the project from the community. We ask that you keep the following guidelines in mind when planning your contribution.
 
 * Whether your contribution is for a bug fix or a feature request, **create an [Issue](https://github.com/intelsdi-x/snap-plugin-collector-cinder/issues)** and let us know what you are thinking.
-* **For bugs**, if you have already found a fix, feel free to submit a Pull Request referencing the Issue you created.
-* **For feature requests**, we want to improve upon the library incrementally which means small changes at a time. In order ensure your PR can be reviewed in a timely manner, please keep PRs small, e.g. <10 files and <500 lines changed. If you think this is unrealistic, then mention that within the issue and we can discuss it.
+* **For bugs**, if you have already found a fix, feel free to submit a Pull Request referencing the Issue you created. Include the `Fixes #` syntax to link it to the issue you're addressing.
+* **For feature requests**, we want to improve upon the library incrementally which means small changes at a time. In order to ensure your PR can be reviewed in a timely manner, please keep PRs small, e.g. <10 files and <500 lines changed. If you think this is unrealistic, then mention that within the issue and we can discuss it.
 
 Once you're ready to contribute code back to this repo, start with these steps:
 
 * Fork the appropriate sub-projects that are affected by your change.
 * Clone the fork to `$GOPATH/src/github.com/intelsdi-x/`:
 
-	```
-	$ git clone https://github.com/<yourGithubID>/<project>.git
-	```
+    ```
+$ git clone https://github.com/<yourGithubID>/<project>.git
+    ```
 * Create a topic branch for your change and checkout that branch:
 
     ```
@@ -31,17 +31,16 @@ Once you're ready to contribute code back to this repo, start with these steps:
 * Commit your changes and push them to your fork.
 * Open a pull request for the appropriate project.
 * Contributors will review your pull request, suggest changes, and merge it when it’s ready and/or offer feedback.
-* To report a bug or issue, please open a new issue against this repository.
 
 If you have questions feel free to contact the [maintainers](https://github.com/intelsdi-x/snap/blob/master/README.md#maintainers) by tagging them: @intelsdi-x/plugin-maintainers.
 
 ## Contributing Examples
 The most immediately helpful way you can benefit this project is by cloning the repository, adding some further examples and submitting a pull request.
 
-Have you written a blog post about how you use Snap? Send it to us [on Gitter](https://gitter.im/intelsdi-x/snap)!
+Have you written a blog post about how you use [Snap](http://github.com/intelsdi-x/snap) and/or this plugin? Send it to us [on Slack](http://slack.snap-telemetry.io)!
 
 ## Contribute Elsewhere
-This repository is one of **many** plugins in **snap**, a powerful telemetry framework. See the full project at http://github.com/intelsdi-x/snap.
+This repository is one of **many** plugins in **Snap**, a powerful telemetry framework. See the full project at http://snap-telemetry.io
 
 ## Thank You
 And **thank you!** Your contribution, through code and participation, is incredibly important to us.

Makefile

@@ -1,10 +1,36 @@
+# File managed by pluginsync
+# http://www.apache.org/licenses/LICENSE-2.0.txt
+#
+#
+# Copyright 2015 Intel Corporation
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 default:
 	$(MAKE) deps
 	$(MAKE) all
 deps:
-	bash -c "godep restore"
+	bash -c "./scripts/deps.sh"
 test:
-	bash -c "./scripts/test.sh $(TEST)"
+	bash -c "./scripts/test.sh $(TEST_TYPE)"
+test-legacy:
+	bash -c "./scripts/test.sh legacy"
+test-small:
+	bash -c "./scripts/test.sh small"
+test-medium:
+	bash -c "./scripts/test.sh medium"
+test-large:
+	bash -c "./scripts/test.sh large"
 check:
 	$(MAKE) test
 all:

openstack/common_test.go

@@ -1,4 +1,4 @@
-// +build unit
+// +build small
 
 /*
 http://www.apache.org/licenses/LICENSE-2.0.txt

scripts/build.sh

@@ -1,26 +1,49 @@
-#!/bin/bash -e
+#!/bin/bash
+# File managed by pluginsync
 
-GITVERSION=`git describe --always`
-SOURCEDIR=$1
-BUILDDIR=$SOURCEDIR/build
-PLUGIN=`echo $SOURCEDIR | grep -oh "snap-.*"`
-ROOTFS=$BUILDDIR/rootfs
-BUILDCMD='go build -a -ldflags "-w"'
+# http://www.apache.org/licenses/LICENSE-2.0.txt
+#
+#
+# Copyright 2016 Intel Corporation
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 
-echo
-echo "****  Snap Plugin Build  ****"
-echo
+set -e
+set -u
+set -o pipefail
+
+__dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+__proj_dir="$(dirname "$__dir")"
+
+# shellcheck source=scripts/common.sh
+. "${__dir}/common.sh"
+
+plugin_name=${__proj_dir##*/}
+build_dir="${__proj_dir}/build"
+go_build=(go build -ldflags "-w")
+
+_info "project path: ${__proj_dir}"
+_info "plugin name: ${plugin_name}"
 
 # Disable CGO for builds
 export CGO_ENABLED=0
 
-# Clean build bin dir
-rm -rf $ROOTFS/*
-
-# Make dir
-mkdir -p $ROOTFS
+# rebuild binaries:
+_debug "removing: ${build_dir:?}/*"
+rm -rf "${build_dir:?}/"*
 
-# Build plugin
-echo "Source Dir = $SOURCEDIR"
-echo "Building Snap Plugin: $PLUGIN"
-$BUILDCMD -o $ROOTFS/$PLUGIN
+_info "building plugin: ${plugin_name}"
+export GOOS=linux
+export GOARCH=amd64
+mkdir -p "${build_dir}/${GOOS}/x86_64"
+"${go_build[@]}" -o "${build_dir}/${GOOS}/x86_64/${plugin_name}" . || exit 1