Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigation arrow fixed for sponsor and testimonial. #30

Merged
merged 18 commits into from
Apr 10, 2024

Conversation

keshav861
Copy link
Contributor

this is the issue #29.
This PR resolves this issue of the navigation arrow which are not present before and now after changes it will be there which will improve the visibility and user experience.
Before:-
image
image
After:-
image
image

the issue has been resolved

mlodic and others added 18 commits July 20, 2023 11:17
add: project summary blog + misc fixes + hover animation
fix: header + links + add author on blogs
@mlodic mlodic changed the base branch from main to develop April 4, 2024 09:10
@mlodic mlodic requested a review from drosetti April 4, 2024 09:10
@mlodic
Copy link
Member

mlodic commented Apr 4, 2024

@drosetti can you plz check this?

Copy link

@drosetti drosetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!
I noticed in the console there are some error logs about the elements with the same index. After you fix it i'll proceed with the merge

@keshav861
Copy link
Contributor Author

ok i will see into the matter.

@keshav861
Copy link
Contributor Author

keshav861 commented Apr 10, 2024

Very good! I noticed in the console there are some error logs about the elements with the same index. After you fix it i'll proceed with the merge

@drosetti I have checked that when we locally run that then it will show error because when i tried to run the website after re cloning and no updates changed on the website then also it is showing the error so i think my code is not the reason for the error same key
image
can you please check that

@drosetti
Copy link

Yes, you're right, this "problem" is not related to the code you changed, but I think this could be a good opportunity to solve this

@keshav861
Copy link
Contributor Author

keshav861 commented Apr 10, 2024

@drosetti yeah I will try to see this error too. Meanwhile you can pass my PR for this issue so this will be resolved. And I have seen that when will see on the uploaded website server where the site is uplinked there it shows no error so I was confused for it that may be possible it is due to local files the name may be common. Not on the server side you may check out.

@drosetti
Copy link

Yeah, I agree with you: the public site is not affect by this problem. I'll merge the pr

@drosetti drosetti merged commit 2a6bbbf into intelowlproject:develop Apr 10, 2024
1 check passed
@keshav861
Copy link
Contributor Author

@drosetti i think there is some problem with the merging of this navigation arrow code the pr is been merged but the changes are not updated in the original code. so i have again send the PR to resolve this issue. please check it and accept the PR.
the issue which was previously merged was issue #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants