Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove postgress sensitive data #59

Merged
merged 3 commits into from
Apr 7, 2024
Merged

fix: remove postgress sensitive data #59

merged 3 commits into from
Apr 7, 2024

Conversation

RazenaSaleem
Copy link
Collaborator

No description provided.

Copy link

gitguardian bot commented Mar 20, 2024

⚠️ GitGuardian has uncovered 101 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9552363 Triggered Generic Password edf4a28 examples/observability-driven-development-go-tracetest/bookstore/part2.1/tracetest/tracetest.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-jaeger/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/observability-driven-development-go-tracetest/bookstore/part3.1/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-amazon-x-ray-adot/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/observability-driven-development-go-tracetest/bookstore/part3.1/tracetest/tracetest.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-go-and-kafka/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-dynatrace/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-provisioning-env/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-signalfx/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-jaeger/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/observability-driven-development-go-tracetest/bookstore/part1/tracetest/tracetest.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-synthetic-monitoring/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-python/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-nodejs-manual-instrumentation/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-signoz-pokeshop/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-datadog-nodejs/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-no-tracing/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-azure-app-insights/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-provisioning-env/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-grafana-cloud-tempo-nodejs/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-amazon-x-ray/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-azure-app-insights-collector/tracetest/tracetest.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-datadog/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-tail-sampling/tracetest/tracetest.config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-go/tracetest/tracetest.config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-azure-app-insights-collector/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-jaeger-nodejs/tracetest/tracetest.config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/collector/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-elasticapm-with-otel/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-amazon-x-ray-pokeshop/tracetest.config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-opensearch/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/collector/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-lightstep-otel-demo/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-honeycomb/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-k6/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-elasticapm-with-otel/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/observability-to-the-rescue/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-python/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-open-telemetry-store-demo/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-new-relic/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-azure-app-insights-pokeshop/tracetest/tracetest.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-signalfx/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-signoz/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-lightstep/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-new-relic-otel-demo/tracetest/tracetest.config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-amazon-x-ray-adot/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/observability-driven-development-go-tracetest/bookstore/part2.2/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/observability-driven-development-go-tracetest/bookstore/part2.2/tracetest/tracetest.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-lightstep-otel-demo/tracetest/tracetest.config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-azure-app-insights-pokeshop/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-net-core/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-go/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-dynatrace/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-tempo-nodejs/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-ruby-sinatra/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-github-actions/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/observability-driven-development-go-tracetest/bookstore/part2.1/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-amazon-x-ray-pokeshop/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-net-core/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-azure-app-insights/tracetest/tracetest.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-signoz/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-lightstep/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-opensearch/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-grafana-tempo-pokeshop/tracetest.config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-go-and-kafka/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-grafana-tempo-pokeshop/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-datadog/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-grafana-cloud-tempo-nodejs/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-new-relic/tracetest/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-ruby-sinatra/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-open-telemetry-store-demo/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-k6/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-nodejs/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-new-relic-otel-demo/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-tempo-nodejs/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-no-tracing/docker-compose.yml View secret
9552363 Triggered Generic Password edf4a28 examples/observability-driven-development-go-tracetest/bookstore/part3.2/tracetest/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/quick-start-tail-sampling/docker-compose.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/tracetest-otel-demo/tracetest-config.yaml View secret
9552363 Triggered Generic Password edf4a28 examples/observability-driven-development-go-tracetest/bookstore/part1/tracetest/docker-compose.yaml View secret

and 21 others.

🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

dryrunsecurity bot commented Mar 20, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Secrets Analyzer (beta) 0 findings
Authn/Authz Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Sensitive Files Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@jebjohns jebjohns changed the title Postgres pwd fix: remove postgress sensitive data Apr 6, 2024
@jebjohns jebjohns merged commit 2b45ef3 into main Apr 7, 2024
7 of 9 checks passed
@RazenaSaleem RazenaSaleem deleted the postgres_pwd branch April 8, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants