Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jsonMarshal string empty check #193

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: jsonMarshal string empty check #193

merged 1 commit into from
Dec 2, 2023

Conversation

mahendraintelops
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c82e053) 61.86% compared to head (87024ef) 61.35%.

Files Patch % Lines
internal/converter/converter.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   61.86%   61.35%   -0.51%     
==========================================
  Files          66       66              
  Lines        4287     4288       +1     
==========================================
- Hits         2652     2631      -21     
- Misses       1299     1312      +13     
- Partials      336      345       +9     
Flag Coverage Δ
core 61.35% <0.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahendraintelops mahendraintelops merged commit 0790d0d into main Dec 2, 2023
@mahendraintelops mahendraintelops deleted the fix-errors branch December 11, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant