Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async saver saves DeepSpeed checkpoint. #892

Merged

Conversation

workingloong
Copy link
Collaborator

What changes were proposed in this pull request?

Async saver saves DeepSpeed checkpoint.

Why are the changes needed?

Fix #836

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (251b604) 77.74% compared to head (06b262c) 77.77%.
Report is 1 commits behind head on master.

Files Patch % Lines
dlrover/python/elastic_agent/torch/ckpt_saver.py 82.30% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   77.74%   77.77%   +0.03%     
==========================================
  Files         167      167              
  Lines       15253    15361     +108     
==========================================
+ Hits        11858    11947      +89     
- Misses       3395     3414      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hxdtest hxdtest merged commit 8240bf0 into intelligent-machine-learning:master Dec 18, 2023
13 checks passed
@workingloong workingloong deleted the deepspeed-ckpt-saver branch December 18, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asynchronously save checkpoint into the storage for DeepSpeed.
2 participants