support async checkpointing for sharding parameters #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2023 17:26
…ing checkpoint async
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #870 +/- ##
==========================================
- Coverage 76.79% 76.75% -0.04%
==========================================
Files 165 165
Lines 14557 14796 +239
==========================================
+ Hits 11179 11357 +178
- Misses 3378 3439 +61 ☔ View full report in Codecov by Sentry. |
workingloong
reviewed
Dec 4, 2023
workingloong
reviewed
Dec 4, 2023
workingloong
reviewed
Dec 5, 2023
workingloong
reviewed
Dec 5, 2023
workingloong
reviewed
Dec 5, 2023
workingloong
reviewed
Dec 5, 2023
added 4 commits
December 5, 2023 19:30
# Conflicts: # dlrover/python/elastic_agent/torch/ckpt_saver.py # dlrover/python/tests/test_ckpt_saver.py
workingloong
merged commit 04db873
into
intelligent-machine-learning:master
11 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
implement ShardingSaver and ShardingCheckpointEngine for saving sharding checkpoint
Why are the changes needed?
same framework sharding the parameter and optim state across ranks.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
UT