[#538]Add device_type function and warning messages #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antlera
merged commit f6ea2db
into
intelligent-machine-learning:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request proposes a modification to the device_type function in the codebase. The changes involve determining the device type based on the input string, which is used to specify the device type (e.g., "gpu" , "Gpu01"or "cuda" for GPU, and "cpu" for CPU).
Why are the changes needed?
The purpose behind these changes is to improve the device type determination logic in the device_type function.
Does this PR introduce any user-facing change?
Yes, this PR introduces user-facing changes in the form of log messages. If the input string indicates a GPU device (e.g., "gpu" or "cuda"), the function now handles the variations in user input and provides a more informative message. If the input string is not recognized, the function also gives feedback about the unrecognized argument and defaults to using the CPU device.
How was this patch tested?
Use different parameter configurations for the 'device' argument and check the relevant logs.